[Fix-17971] Fix ProcedureTask can not pass out parameter and can not execute query procedure.#17973
Open
ruanwenjun wants to merge 1 commit intoapache:devfrom
Open
[Fix-17971] Fix ProcedureTask can not pass out parameter and can not execute query procedure.#17973ruanwenjun wants to merge 1 commit intoapache:devfrom
ruanwenjun wants to merge 1 commit intoapache:devfrom
Conversation
ruanwenjun
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_fix17971
branch
2 times, most recently
from
51dd4e9 to
6d6a353
Compare
Member
Author
|
@njnu-seafish @Mrhs121 Please take a look. |
ruanwenjun
force-pushed
the
dev_wenjun_fix17971
branch
3 times, most recently
from
8bee98f to
b5d9736
Compare
3 tasks
ruanwenjun
changed the title
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_fix17971
branch
2 times, most recently
from
ce62e7e to
be879ea
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fix17971
branch
from
be879ea to
e6e3581
Compare
Mrhs121
reviewed
Feb 15, 2026
| Map<String, Property> prepareParams) throws Exception { | ||
| Map<Integer, Property> outParameterMap = new HashMap<>(); | ||
| if (procedureParameters.getLocalParametersMap() == null) { | ||
| if (MapUtils.isEmpty(sqlParams)) { |
Contributor
There was a problem hiding this comment.
#17971 @honkerjha The key fix to solve this issue
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17971
close #17972
Brief change log
ProcedureParameters, remove get/set/toString method, use lombok@Data.getResourceFilesListmethod, since this doesn't change the parent implementation.outPropertysince this doesn't help.Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md