Fix failing ClientCertificateAuthenticationIT #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Damn it.. I'm ashamed I wasn't able to get it fixed :-/ I spent something like 4/6h checking the certificate, stepping the code, and I still missed this trivial part. Thanks Colm ! |
Contributor
|
Note that the added line was not required in AM27, so I wonder why it's now needed... |
Contributor
Author
|
@elecharny I did a git bisect and found that the test started failing from f53aa23 which led me to the fix... |
Contributor
|
Damn it, so trivial, I was blinded by the certificate potential expiration or some other causes :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.