Repository navigation
Make the latest snapshots from every language the default - #15
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the Java snapshot pin from 3a1bf7f to 059b5a9, the merge of apache/datasketches-java#774, and regenerate the Java snapshots. Deterministic changes: - HLL_6 and HLL_8 compact images set the compact flag (java#761). - Empty tuple and AoS compact images write a zero seed hash. - Adds frequent_long_purged and frequent_string_purged (java#770). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the C++ snapshot pin from fe0261a to 16d4ea6 and regenerate the C++ snapshots. Deterministic changes: - Single-item compact theta images set the single-item flag (cpp#526). - Adds frequent_long_purged and frequent_string_purged (cpp#529). - Removes the 27 aos_*_cpp.sk snapshots: the C++ array-of-strings tuple sketch was reverted (cpp#537) because its key hashing is incompatible with Java (cpp#533). All other modifications are probabilistic snapshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`snapshots update` now takes `all` and an optional revision. Without a revision, a source is updated to its default branch, so `snapshots update all` refreshes every source in one command. Pinning a specific branch, tag, or commit for one source remains available for reproducing a release or holding a source back. When several sources are processed, a failure in one no longer stops the others; the command reports every failed source and exits non-zero. An update whose commit is unchanged and whose output differs only in probabilistic snapshots no longer rewrites them, so repeated updates do not add binary churn. A new, non-required workflow runs `snapshots update all` every Monday and on demand, commits the result to main, and fails visibly when a source cannot be generated. The docs now describe main as the latest self-tested snapshots from every source and recommend that consumers test against it by default. Closes #12 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reconcile the snapshot directory migration from #14 with the latest-snapshot update workflow. Preserve the snapshot corpus from main, retain the update behavior, and use serialization_test_data in the workflow and documentation. Validated with mise run check and exact snapshot comparisons against main.
tisonkun
requested changes
Oct 4, 2026
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
I'm reading this.
I remember that I implement sync to avoid update ... intentionally.
Use the existing update <language> <revision> command with HEAD for each source. Keep language enumeration and failure aggregation in the workflow, so one failed generator does not prevent the other sources from updating. Remove update all, the optional revision, their CLI-only validation tests, and the default-branch constant. Update the help snapshot and documentation to match the original single-source interface.
tisonkun
approved these changes
Oct 5, 2026
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
Revert update all to reuse the existing functions.
I'll push a new PR to see if we can refactor the cmd further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12.
The weekly and manually dispatched snapshot workflow updates each upstream source with the existing
snapshots update <language> <revision>interface. It explicitly enumeratescpp,go, andjavaand passesHEADto follow each repository's default branch; the CLI still requires one language and an explicit revision.Language enumeration and failure aggregation belong to the workflow. If one generator fails, the remaining languages are still attempted, successful changes are committed, and the run ultimately fails. The job summary retains each source's revision and change report. The workflow is not a required check and is skipped on forks.
When an upstream commit has not changed and only probabilistic snapshots differ, update mode leaves the files untouched to avoid binary churn. Documentation describes using the latest corpus on
main, with a pinned TCK commit available for reproducibility.Validation:
mise run checkpasses.