chore: code tidy for FrequentItems and impl for more value type#82
Merged
chore: code tidy for FrequentItems and impl for more value type#82
Conversation
Signed-off-by: tison <wander4096@gmail.com>
This reverts commit 98082a5.
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @PsiACE @AlexanderSaydakov @leerho @notfilippo
In the first commit I implement a generic solution to extend
FrequentItemsfor anyFrequentItemValue.But it would require to expose
SketchSliceandSketchBytesas well.So I tend to keep the abstraction internal only for a while until we're sure that expsoing codec struct is the right way to go.