ordered runs, simplified insertion code #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dickens
reviewed
Jun 5, 2024
| boolean existing_is_continuation = is_continuation(index); | ||
| boolean is_continuation = !is_run_start; | ||
| boolean is_shifted = index != canonical; | ||
| boolean force_continuation = !is_new_run && is_run_start; |
There was a problem hiding this comment.
Can you add a comment explaining why the force_continuation flag is necessary?
c-dickens
reviewed
Jun 5, 2024
c-dickens
left a comment
c-dickens
left a comment
There was a problem hiding this comment.
Minor comment on continuation flag
c-dickens
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.