Use REQUIRE_THROWS_WITH to check for error message#455
Merged
AlexanderSaydakov merged 1 commit intoapache:masterfrom May 28, 2025
Merged
Use REQUIRE_THROWS_WITH to check for error message#455AlexanderSaydakov merged 1 commit intoapache:masterfrom
AlexanderSaydakov merged 1 commit intoapache:masterfrom
Conversation
Pull Request Test Coverage Report for Build 15238016718Details
💛 - Coveralls |
AlexanderSaydakov
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this test
was still passing even though
suggest_num_bucketsthrows the following error message:"Relative error must be at least 0."instead of"Confidence must be between 0 and 1.0 (inclusive).".This is because
REQUIRE_THROWSdoesn't check if the error message matches.REQUIRE_THROWS_WITHshould be used instead.