Fix panic in struct function with mixed scalar/array arguments
#9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 24, 2024
| }) | ||
| }) | ||
| .collect::<Result<Vec<ArrayRef>>>()?; | ||
| let arrays = ColumnarValue::values_to_arrays(args)?; |
There was a problem hiding this comment.
I also filed
I also filed #9774 to improve the documentation
alamb
commented
Mar 24, 2024
| .map(|x| { | ||
| Ok(match x { | ||
| ColumnarValue::Array(array) => array.clone(), | ||
| ColumnarValue::Scalar(scalar) => scalar.to_array()?.clone(), |
There was a problem hiding this comment.
the bug here is that this always makes a 1 row array, even if one of the other arguments has more than 1 row.
yyy1000
approved these changes
Mar 24, 2024
Thanks @yyy1000 ! It certainly didn't have test coverage either, and I think that bug has existed for quite a while |
viirya
approved these changes
Mar 24, 2024
|
Thank you for the review @viirya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #9773
Rationale for this change
Bug (see #9773)
What changes are included in this PR?
Fix bug by calling the correct api, add test
Are these changes tested?
Yes, new test
Are there any user-facing changes?
Less bugs