Port Array Union and Intersect to functions-array
#9629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jayzhan211
commented
Mar 16, 2024
| @@ -105,7 +105,8 @@ impl ScalarUDFImpl for MakeArray { | |||
| } | |||
| } | |||
|
|
|||
| /// `make_array` SQL function | |||
| /// `make_array_inner` is the implementation of the `make_array` function. | |||
| /// Can be used if the expected input and output are ArrayRef | |||
| pub(crate) fn make_array_inner(arrays: &[ArrayRef]) -> Result<ArrayRef> { | |||
There was a problem hiding this comment.
rename to avoid conflict with function name
|
I am considering moving |
43 tasks
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
comphead
reviewed
Mar 16, 2024
| @@ -105,7 +105,8 @@ impl ScalarUDFImpl for MakeArray { | |||
| } | |||
| } | |||
|
|
|||
| /// `make_array` SQL function | |||
| /// `make_array_inner` is the implementation of the `make_array` function. | |||
There was a problem hiding this comment.
Suggested change
| /// `make_array_inner` is the implementation of the `make_array` function. | |
| /// Constructs an array using the input `data` as `ArrayRef`. | |
| /// Returns a reference-counted `Array` instance result. |
comphead
reviewed
Mar 16, 2024
| @@ -105,7 +105,8 @@ impl ScalarUDFImpl for MakeArray { | |||
| } | |||
| } | |||
|
|
|||
| /// `make_array` SQL function | |||
| /// `make_array_inner` is the implementation of the `make_array` function. | |||
| /// Can be used if the expected input and output are ArrayRef | |||
There was a problem hiding this comment.
Suggested change
| /// Can be used if the expected input and output are ArrayRef |
comphead
approved these changes
Mar 16, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts of #9285
Rationale for this change
What changes are included in this PR?
move
array distincttoset_opsAre these changes tested?
Are there any user-facing changes?