Move all crypto related functions to datafusion-functions
#9590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Lordworms
changed the title
alamb
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Very nice @Lordworms -- thank you very much. This looks great to me
| @@ -1510,44 +1447,6 @@ mod tests { | |||
| Utf8, | |||
| StringArray | |||
| ); | |||
| #[cfg(feature = "crypto_expressions")] | |||
There was a problem hiding this comment.
I double checked and these functions are covered in .slt tests here https://github.com/apache/arrow-datafusion/blob/30d2be9f581846c4b6f875424512eaa7310e16ab/datafusion/sqllogictest/test_files/expr.slt#L1373-L1556
I don't think there is any need to port these rust unit tests too
alamb
changed the title
crypto related functions to datafusion-functions
|
I took the liberty of merging this PR up from main to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9509
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?