Minior: Add tests with sqrt with negative argument
#9426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please forgive me for adding some negative tests at will. I am not sure whether it is appropriate to add negative tests to scalar.slt. I am compiling a negative test document about the math function. Can I add the negative test I compiled in the next PR? |
Thank you @caicancai -- adding tests is always appreciated. Thank you |
alamb
approved these changes
Mar 2, 2024
alamb
changed the title
sqrt with negative argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Add negative tests about sqrt function
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?