Return an error when a column does not exist in window function

[PhVHoang]

Which issue does this PR close?

Closes #9166.

Rationale for this change

To return an error instead of panicking when columns don't exist in window function.

What changes are included in this PR?

Code, tests

Are these changes tested?

Yes

Are there any user-facing changes?

[alamb]

Thank you @PhVHoang -- this is a great first contribution.

I think the code can be made simpler and I left a comment for your consideration

[alamb]

I think the ok() function call here discards the error.

I think changing

                        let idx = schema.index_of_column(col).unwrap();

To

                        let idx = schema.index_of_column(col).ok()?;

accomplishes the same thing (and your test still passes)

[PhVHoang]

Thank you very much for your suggestion. Yes it's way simpler than that of mine.

Fixed.

[alamb]

Thank you @PhVHoang -- this looks good to me

I think it would be good if @mustafasrepo could also review this PR before we merge, if he has time

[comphead]

lgtm thanks @PhVHoang
its better than crash

[comphead]

@PhVHoang please add the test also for non existent partition by column
and qualified column like t.a, schema.t.a, catalog.schema.t.a

[mustafasrepo]

Thanks @PhVHoang for this PR. LGTM!

[alamb]

@PhVHoang please add the test also for non existent partition by column and qualified column like t.a, schema.t.a, catalog.schema.t.a

I think the only thing remaining before merging this PR is the suggestion from @comphead #9202 (comment) for a few more tests. I can add them hopefully later today if no one else has a chance

[PhVHoang]

@alamb @comphead I added some more tests. Please take a look and let me know if these tests are sufficient for this change.

[comphead]

lgtm thanks @PhVHoang

[alamb]

Thanks again everyone