Skip to content

Conversation

@Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Jan 21, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

4289737 sped win ci up, running at 33min:

Following commit dd4263f had runtime of 39min:

Subsequent runs fall around 39-42min range

Until this commit d9a1d42 which causes runtime of 47min:

Subsequent runs (up to latest main) fall around 44-48min range

What changes are included in this PR?

Fix accidental regression by d9a1d42 which named the env var incorrectly.

Are these changes tested?

Are there any user-facing changes?

@Jefffrey Jefffrey changed the title [CI] Test speeding up win ci [CI] Fix RUSTFLAGS Jan 22, 2024
@Jefffrey
Copy link
Contributor Author

Two commit action runs with fix:

Fixes d9a1d42

For dd4263f I'm not sure if the slowdown was due to setting RUST_MIN_STACK or due to the code changes. If it was due to the RUST_MIN_STACK then hopefully should be resolved by #8837

@Jefffrey Jefffrey marked this pull request as ready for review January 22, 2024 10:58
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Jefffrey for fixing that nasty typo

@comphead
Copy link
Contributor

Basically CI times fluctuates, I saw Macos builds being 19 mins, and on the same codebase the next run 28mins.

@alamb alamb merged commit 6816d3f into apache:main Jan 22, 2024
@alamb
Copy link
Contributor

alamb commented Jan 22, 2024

Thanks @Jefffrey and @comphead

@Jefffrey Jefffrey deleted the ci_speed_up_win branch January 22, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants