-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: Port tests in partitioned_csv.rs
to sqllogictest
#8919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,3 +63,76 @@ id6 value"6 | |
id7 value"7 | ||
id8 value"8 | ||
id9 value"9 | ||
|
||
|
||
# Read partitioned csv | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
statement ok | ||
CREATE TABLE src_table_1 ( | ||
int_col INT, | ||
string_col TEXT, | ||
bigint_col BIGINT, | ||
partition_col INT | ||
) AS VALUES | ||
(1, 'aaa', 100, 1), | ||
(2, 'bbb', 200, 1), | ||
(3, 'ccc', 300, 1), | ||
(4, 'ddd', 400, 1); | ||
|
||
statement ok | ||
CREATE TABLE src_table_2 ( | ||
int_col INT, | ||
string_col TEXT, | ||
bigint_col BIGINT, | ||
partition_col INT | ||
) AS VALUES | ||
(5, 'eee', 500, 2), | ||
(6, 'fff', 600, 2), | ||
(7, 'ggg', 700, 2), | ||
(8, 'hhh', 800, 2); | ||
|
||
query ITII | ||
COPY src_table_1 TO 'test_files/scratch/csv_files/csv_partitions/1.csv' | ||
(FORMAT CSV, SINGLE_FILE_OUTPUT true); | ||
---- | ||
4 | ||
|
||
|
||
query ITII | ||
COPY src_table_2 TO 'test_files/scratch/csv_files/csv_partitions/2.csv' | ||
(FORMAT CSV, SINGLE_FILE_OUTPUT true); | ||
---- | ||
4 | ||
|
||
statement ok | ||
CREATE EXTERNAL TABLE partitioned_table ( | ||
int_col INT, | ||
string_col TEXT, | ||
bigint_col BIGINT, | ||
partition_col INT | ||
) | ||
STORED AS CSV | ||
WITH HEADER ROW | ||
LOCATION 'test_files/scratch/csv_files/csv_partitions'; | ||
|
||
query ITII | ||
SELECT * FROM partitioned_table ORDER BY int_col; | ||
---- | ||
1 aaa 100 1 | ||
2 bbb 200 1 | ||
3 ccc 300 1 | ||
4 ddd 400 1 | ||
5 eee 500 2 | ||
6 fff 600 2 | ||
7 ggg 700 2 | ||
8 hhh 800 2 | ||
|
||
query TT | ||
EXPLAIN SELECT * FROM partitioned_table ORDER BY int_col; | ||
---- | ||
logical_plan | ||
Sort: partitioned_table.int_col ASC NULLS LAST | ||
--TableScan: partitioned_table projection=[int_col, string_col, bigint_col, partition_col] | ||
physical_plan | ||
SortPreservingMergeExec: [int_col@0 ASC NULLS LAST] | ||
--SortExec: expr=[int_col@0 ASC NULLS LAST] | ||
----CsvExec: file_groups={2 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/csv_files/csv_partitions/1.csv], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/csv_files/csv_partitions/2.csv]]}, projection=[int_col, string_col, bigint_col, partition_col], has_header=true |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same code existed in
partitioned_csv.rs
andmod.rs
- dropped the former and replaced with function calls tomod.rs