Support array literal with scalar function #8884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jackwener
reviewed
Jan 16, 2024
| @@ -459,7 +459,7 @@ AS | |||
| query error | |||
| select [1, true, null] | |||
|
|
|||
| query error DataFusion error: This feature is not implemented: ScalarFunctions without MakeArray are not supported: now() | |||
There was a problem hiding this comment.
Can we add more to covert Struct?
9 tasks
alamb
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
looks good to me, thank you @jayzhan211
Now that I am looking at this code, I wonder why array literals can't support functions 🤔 I bet they could given they are just arguments passed to a function now
True |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
changed the title
alamb
approved these changes
Jan 18, 2024
| } | ||
| } | ||
| } | ||
| let values = elements |
There was a problem hiding this comment.
I love it -- less code and more functionality ❤️ !
|
Forgot to convert back from draft, this is ready to merge! |
jackwener
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8873
Closes #8867
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?