Skip to content

test: Port tests in predicates.rs to sqllogictest #8879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

simicd
Copy link
Contributor

@simicd simicd commented Jan 15, 2024

Which issue does this PR close?

Closes #8209.

Rationale for this change

Migrate remaining Rust unit tests in predicates.rs to sqllogictest

What changes are included in this PR?

  • Port remaining unit tests
  • Remove unused code

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jan 15, 2024
@simicd simicd changed the title test: Port tests in ´predicates.rs´ to sqllogictest test: Port tests in predicates.rs to sqllogictest Jan 15, 2024
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simicd

@jackwener jackwener merged commit b64ad79 into apache:main Jan 16, 2024
@alamb
Copy link
Contributor

alamb commented Jan 16, 2024

❤️

@simicd simicd deleted the test/predicates-sqllogictest branch January 16, 2024 16:50
@simicd
Copy link
Contributor Author

simicd commented Jan 16, 2024

Thanks for the review @jackwener & @Ted-Jiang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port tests in predicates.rs to sqllogictest
4 participants