fix bug with to_timestamp and InitCap logical serialization, add roundtrip test between expression and proto,
#8868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 15, 2024
|
|
||
| let ctx = SessionContext::new(); | ||
| let lit = Expr::Literal(ScalarValue::Utf8(None)); | ||
| for builtin_fun in BuiltinScalarFunction::iter() { |
|
Interestingly, when I run this test on #8847 it fails with a different function |
alamb
changed the title
alamb
approved these changes
Jan 15, 2024
| @@ -1588,7 +1588,7 @@ pub fn parse_expr( | |||
| Ok(character_length(parse_expr(&args[0], registry)?)) | |||
| } | |||
| ScalarFunction::Chr => Ok(chr(parse_expr(&args[0], registry)?)), | |||
| ScalarFunction::InitCap => Ok(ascii(parse_expr(&args[0], registry)?)), | |||
| ScalarFunction::InitCap => Ok(initcap(parse_expr(&args[0], registry)?)), | |||
datafusion/proto/Cargo.toml
Outdated
| @@ -51,6 +51,7 @@ pbjson = { version = "0.6.0", optional = true } | |||
| prost = "0.12.0" | |||
| serde = { version = "1.0", optional = true } | |||
| serde_json = { workspace = true, optional = true } | |||
| strum = { version = "0.25.0", features = ["derive"] } | |||
There was a problem hiding this comment.
BTW since this module is only used in the tests, we should put it in the dev-dependencies section, so everyone using datafusion-proto does not need to compile it as well
I did this in 0a41737
alamb
changed the title
to_timestamp and InitCap logical serialization, add roundtrip test between expression and proto,
This was referenced Jan 15, 2024
andygrove
reviewed
Jan 16, 2024
andygrove
approved these changes
Jan 16, 2024
comphead
reviewed
Jan 16, 2024
Yes, it is. @comphead |
comphead
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts. #8847
Rationale for this change
When I worked on #8847, there were wrong function calls in
parse_expr, the ci did not notify it.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?