Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: array_pop_first should be array_pop_front in documentation #8797

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Minor: array_pop_first should be array_pop_front in documentation #8797

merged 1 commit into from
Jan 9, 2024

Conversation

ongchi
Copy link
Contributor

@ongchi ongchi commented Jan 9, 2024

Which issue does this PR close?

None

Rationale for this change

Fix typo in scalar functions documentation.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

jayzhan211
jayzhan211 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

comphead
comphead approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @ongchi

alamb
alamb approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Execution error: array_pop_front does not support type: Utf8
❯ select array_pop_first('f');
Error during planning: Invalid function 'array_pop_first'.
Did you mean 'array_pop_front'?

Thank you @ongchi

@alamb alamb merged commit 72cfc80 into apache:main Jan 9, 2024
4 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 9, 2024

Thanks for the review @jayzhan211

@ongchi ongchi deleted the fix-typo-sql-ref-scalar-func branch February 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayzhan211 jayzhan211 jayzhan211 approved these changes

@comphead comphead comphead approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ongchi @alamb @comphead @jayzhan211