Support for extract(epoch from date) for Date32 and Date64
#8695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
7 tasks
alamb
approved these changes
Dec 31, 2023
| @@ -754,6 +755,39 @@ async fn test_extract_epoch() -> Result<()> { | |||
| "946684800.0" | |||
| ); | |||
| test_expression!("extract(epoch from NULL::timestamp)", "NULL"); | |||
| // date | |||
There was a problem hiding this comment.
👍 I double checked this is consistent with postgres:
postgres=# select extract(epoch from '1970-01-01'::date);
extract
---------
0
(1 row)
postgres=# select extract(epoch from '1970-01-02'::date);
extract
---------
86400
(1 row)
postgres=# select extract(epoch from '1969-12-31'::date);
extract
---------
-86400
(1 row)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8694
Rationale for this change
What changes are included in this PR?
Support extracting seconds since epoch for Date32 and Date64 types
Are these changes tested?
Are there any user-facing changes?