Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for conflicting order sensitive aggregates in ARRAY_AGG aggregate function #8558

Closed
wants to merge 56 commits into from
Closed

Add support for conflicting order sensitive aggregates in ARRAY_AGG aggregate function #8558

wants to merge 56 commits into from

Commits on Nov 30, 2023

  1. Array agg ordered initial implementation

    @mustafasrepo
    mustafasrepo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    8d8249e View commit details
    Browse the repository at this point in the history

  2. Minor changes

    @mustafasrepo
    mustafasrepo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    8f54037 View commit details
    Browse the repository at this point in the history

  3. Add tests for first_value, last_value

    @mustafasrepo
    mustafasrepo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7484c10 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Add new tests

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    071b266 View commit details
    Browse the repository at this point in the history

  2. Add first, last tests

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6b77b40 View commit details
    Browse the repository at this point in the history

  3. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    49d5f27 View commit details
    Browse the repository at this point in the history

  4. Simplifications

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7704b97 View commit details
    Browse the repository at this point in the history

  5. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b803a6f View commit details
    Browse the repository at this point in the history

  6. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5913e0c View commit details
    Browse the repository at this point in the history

  7. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4a4f1f8 View commit details
    Browse the repository at this point in the history

  8. Resolve linter errors

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    18815ea View commit details
    Browse the repository at this point in the history

  9. Remove clone

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    edf5c5c View commit details
    Browse the repository at this point in the history

  10. Remove unused code

    @mustafasrepo
    mustafasrepo committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ea6d94a View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Add grouping support

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ffbe3bc View commit details
    Browse the repository at this point in the history

  2. Implement grouping algorithm

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5c05f50 View commit details
    Browse the repository at this point in the history

  3. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d7ead93 View commit details
    Browse the repository at this point in the history

  4. Add reverse support

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    019b9ba View commit details
    Browse the repository at this point in the history

  5. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e4b9ebc View commit details
    Browse the repository at this point in the history

  6. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e2ee90a View commit details
    Browse the repository at this point in the history

  7. All cli tests pass

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e0f2889 View commit details
    Browse the repository at this point in the history

  8. Simplifications

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    16af57f View commit details
    Browse the repository at this point in the history

  9. Resolve linter errors

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d442e84 View commit details
    Browse the repository at this point in the history

  10. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    8c7b316 View commit details
    Browse the repository at this point in the history

  11. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b4003da View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Update comments, cleanup

    @mustafasrepo
    mustafasrepo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    69e5f59 View commit details
    Browse the repository at this point in the history

  2. Add proper indices handling

    @mustafasrepo
    mustafasrepo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b848f4e View commit details
    Browse the repository at this point in the history

  3. Minnor changes

    @mustafasrepo
    mustafasrepo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    80a160c View commit details
    Browse the repository at this point in the history

  4. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    89e0c2b View commit details
    Browse the repository at this point in the history

  5. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    299e89c View commit details
    Browse the repository at this point in the history

  6. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    a2723e5 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Remove requirement originating from order sensitive aggregators

    @mustafasrepo
    mustafasrepo committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    373dd88 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apache_main' into feature/conflicting_order_sensitive_a… 

    …ggregates

# Conflicts:
#	datafusion/physical-plan/src/aggregates/mod.rs
    @mustafasrepo
    mustafasrepo committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6836e02 View commit details
    Browse the repository at this point in the history

  3. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f375bc4 View commit details
    Browse the repository at this point in the history

  4. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    96ac322 View commit details
    Browse the repository at this point in the history

  5. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    163b056 View commit details
    Browse the repository at this point in the history

  6. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b813071 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'apache_main' into feature/conflicting_order_sensitive_a… 

    …ggregates

# Conflicts:
#	datafusion/physical-expr/src/aggregate/array_agg_ordered.rs
#	datafusion/sqllogictest/test_files/groupby.slt
    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1754719 View commit details
    Browse the repository at this point in the history

  2. Fix changing tests

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    eb97d99 View commit details
    Browse the repository at this point in the history

  3. Initial review

    @metesynnada
    metesynnada committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    43c33ae View commit details
    Browse the repository at this point in the history

  4. Partial not working commit

    @metesynnada
    metesynnada committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    be85af3 View commit details
    Browse the repository at this point in the history

  5. Simplifications

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    74825e9 View commit details
    Browse the repository at this point in the history

  6. Update mod.rs

    @metesynnada
    metesynnada committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9703390 View commit details
    Browse the repository at this point in the history

  7. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f58b760 View commit details
    Browse the repository at this point in the history

  8. No grouping refactor

    @metesynnada
    metesynnada committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    585fdc8 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feature/conflicting_order_sensitive_aggregates' of http… 

    …s://github.com/synnada-ai/arrow-datafusion into feature/conflicting_order_sensitive_aggregates
    @metesynnada
    metesynnada committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8c25f0d View commit details
    Browse the repository at this point in the history

  10. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    184865e View commit details
    Browse the repository at this point in the history

  11. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b5a250c View commit details
    Browse the repository at this point in the history

  12. Minor changes

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    77b5c06 View commit details
    Browse the repository at this point in the history

  13. instead of input use equivalence

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    86cf0b9 View commit details
    Browse the repository at this point in the history

  14. Update proto

    @mustafasrepo
    mustafasrepo committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2ce128d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge branch 'apache_main' into feature/conflicting_order_sensitive_a… 

    …ggregates

# Conflicts:
#	datafusion/sqllogictest/test_files/joins.slt
    @mustafasrepo
    mustafasrepo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    bda3e2a View commit details
    Browse the repository at this point in the history

  2. Fix test display

    @mustafasrepo
    mustafasrepo committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    16596b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'apache_main' into feature/conflicting_order_sensitive_a… 

    …ggregates

# Conflicts:
#	datafusion/physical-plan/src/aggregates/mod.rs
    @mustafasrepo
    mustafasrepo committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    42e3631 View commit details
    Browse the repository at this point in the history

  2. Minor

    @metesynnada
    metesynnada committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b378f80 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Merge branch 'apache_main' into feature/conflicting_order_sensitive_a… 

    …ggregates

# Conflicts:
#	datafusion/sqllogictest/test_files/groupby.slt
    @mustafasrepo
    mustafasrepo committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    c0dfe04 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge branch 'apache_main' into feature/conflicting_order_sensitive_a… 

    …ggregates

# Conflicts:
#	datafusion/physical-plan/src/aggregates/mod.rs
#	datafusion/sqllogictest/test_files/groupby.slt
    @mustafasrepo
    mustafasrepo committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    48fe203 View commit details
    Browse the repository at this point in the history