refactor: support bitmap for u8/16 and i8/16 in approx_distinct#8462
refactor: support bitmap for u8/16 and i8/16 in approx_distinct#8462Weijun-H wants to merge 3 commits intoapache:mainfrom
approx_distinct#8462Conversation
approx_distinct
| } | ||
|
|
||
| fn size(&self) -> usize { | ||
| self.bitmap.serialized_size() |
There was a problem hiding this comment.
Not sure is a proper way to measure roaring bitmap
|
Thank you @Weijun-H! This PR, though, looks like the implementation of |
|
I wonder what we should do with this PR now we have |
While I'm still not sure if this PR fits |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Follow #1841
Closes #1109
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?