-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR]: Remove unecessary orderings from the final plan #8289
Conversation
(this doesn't exactly do the right thing -- we will update this today and re-open) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @alamb, would appreciate a quick look from you
// | ||
// More rationale: | ||
// https://github.com/apache/arrow-datafusion/pull/6354#discussion_r1195284178 | ||
match &self.sort_order { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We experienced some problems with this as well (added sorts), so happy to see this go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mustafasrepo and @Dandandan
------Projection: aggregate_test_100.c2, aggregate_test_100.c1 | ||
--------TableScan: aggregate_test_100 projection=[c1, c2] | ||
physical_plan | ||
AggregateExec: mode=FinalPartitioned, gby=[c2@0 as c2], aggr=[COUNT(*)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 it is nice to see no Sort!
Which issue does this PR close?
Closes #.
Rationale for this change
In some of the plans, there are unnecessary
SortExec
, where ordered fields are not used (exist at the final plan.) This PR removeSortExec
s for these cases from the plan.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?