Skip to content

Conversation

@tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Fixes logical conflicts introduced by #8169 and #8079

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@tustvold tustvold added the development-process Related to development process of DataFusion label Nov 15, 2023
@github-actions github-actions bot added core Core DataFusion crate substrait Changes to the substrait crate and removed development-process Related to development process of DataFusion labels Nov 15, 2023
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold. This seems to resolve both logical conflicts at the same time, right? If I'm not mistaken let's just merge this when CI passes then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants