Support hashing List columns #7616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Very nice @jonmmease -- thank you very much 👏
I reviewed the code and tests and it looks good to me
xudong963
approved these changes
Sep 22, 2023
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
* Hash ListArray * Implement hash join for list arrays * add sqllogic test for grouping by list column * reset parquet-testing * reset testing * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7473
Rationale for this change
I'd like to be able to group by a List column
What changes are included in this PR?
Follows suggestion by @tustvold to hash List arrays by first hashing the inner values array and then using the list offsets to combine hashes within each list element.
Are these changes tested?
Yes, there is a unit test for the hash logic itself and an sqllogic test for the desired groupby behavior
Are there any user-facing changes?
GROUP BY on a list column will no longer error