Skip to content

Minor: add ticket references to parallel parquet writing code #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Sep 28, 2023
Merged

Minor: add ticket references to parallel parquet writing code #7592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions datafusion/core/src/datasource/file_format/parquet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,8 @@ async fn output_single_parquet_file_parallelized(
parquet_props: &WriterProperties,
) -> Result<usize> {
let mut row_count = 0;
// TODO decrease parallelism / buffering:
// https://github.com/apache/arrow-datafusion/issues/7591
let parallelism = data.len();
let mut join_handles: Vec<JoinHandle<ParquetFileSerializedResult>> =
Vec::with_capacity(parallelism);
Expand Down Expand Up @@ -881,6 +883,8 @@ async fn output_single_parquet_file_parallelized(
>,
> = tokio::task::spawn(async move {
while let Some(data) = rx.recv().await {
// TODO write incrementally
// https://github.com/apache/arrow-datafusion/issues/7591
object_store_writer.write_all(data.as_slice()).await?;
}
Ok(object_store_writer)
Expand Down Expand Up @@ -917,6 +921,8 @@ async fn output_single_parquet_file_parallelized(
bytes_written: column.compressed_size() as _,
rows_written: rg.num_rows() as _,
metadata: column.clone(),
// TODO need to populate the indexes when writing final file
// see https://github.com/apache/arrow-datafusion/issues/7589
bloom_filter: None,
column_index: None,
offset_index: None,
Expand Down