Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify code of eliminate_cross_join.rs #7561

Merged
merged 1 commit into from
Sep 16, 2023
Merged

refactor: simplify code of eliminate_cross_join.rs #7561

merged 1 commit into from
Sep 16, 2023

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Sep 14, 2023 •
edited
Loading

Which issue does this PR close?

N/A

Rationale for this change

simplify code of eliminate_cross_join.rs

What changes are included in this PR?

Are these changes tested?

N/A

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules labels Sep 14, 2023
alamb
alamb approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice change to me -- thank you @jackwener

@alamb alamb merged commit 93f78b2 into apache:main Sep 16, 2023
21 checks passed
@jackwener jackwener deleted the refactor branch September 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwener @alamb