[MINOR]: Move tests from repartition to enforce_distribution file #7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metesynnada
approved these changes
Sep 13, 2023
Dandandan
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In the PR#7488. We combined
RepartitionandEnforceDistiributionrule into single rule. To not clutter that PR, with file changes, and code moving. I kept tests underrepartition.rsfile in that file. Even though that file no longer contained a rule implementation.What changes are included in this PR?
With this PR, we move tests under
repartition.rsto underenforce_distribution.rsso that tests will be under relevant file.Please note that some tests are not exactly equal (schemas are different, etc, utils construct sligtly different executors etc). But they are equal in the spirit.
Are these changes tested?
Existing tests should work
Are there any user-facing changes?