fix pyarrow type id mapping in python crate
#742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
force-pushed
the
py-types
branch
3 times, most recently
from
2502cc5 to
612d53d
Compare
jimexist
commented
Jul 18, 2021
| 22 => DataType::LargeBinary, | ||
| 23 => DataType::LargeUtf8, | ||
|
|
||
| 13 => DataType::Utf8, |
Member
Author
There was a problem hiding this comment.
previously it'll throw because pa.string() is with id 13, not 20
alamb
approved these changes
Jul 18, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
looks good to me, but I admit to not having much experience with this code. @jorgecarleitao or @kszucs do you have any thoughts here?
| (10, pa.float16()), | ||
| (11, pa.float32()), | ||
| (12, pa.float64()), | ||
| (13, pa.string()), |
houqp
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
fix pyarrow type id mapping in
pythoncrateCloses #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?