ScalarFunctionExpr Maintaining Order #7417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their preservation of order
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
…m/synnada-ai/arrow-datafusion into feature/scalar-func-expr-ordering
github-actions
bot
added
physical-expr
|
I believe CI will pass after merging up from |
|
@alamb I have synced the branch. If no objection, the PR is ready to merge. |
|
There doesn't seem to be any concerns about this, so I will go ahead with merging. Should there be any issues, we will address via quick follow-on PRs. |
Sorry I was on vacation -- thanks for merging it and moving things along! |
alamb
reviewed
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
After
ProjectionExecis able to propagate the orders of non-column expressions, it is also possible to preserve the order of someScalarFunctionExpr's. This PR implements that feature.This PR is the 3rd step of #7296 and #7364 PR's. Now, we have the support of propagating the sort order over different kinds of
PhysicalExpr's at the projection stage.What changes are included in this PR?
While creating
ScalarFunctionExpr, we check its order preservation info fromBuiltinScalarFunction.math_expressionsanddatetime_expressionsare labeled according to their functional monotonicity.ScalarFunctionExprnow has a fieldmonotonicity: Option<FuncMonotonicity>.FuncMonotonicitykeeps monotonicity information of the function. It is one to one mapped toargsof the function, and it specifies the effect of an increase or decrease in the correspondingargto the function value.Are these changes tested?
Yes, by .slt tests with some of the functions.
Are there any user-facing changes?