Replace lazy_static with OnceLock #7409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
viirya
approved these changes
Aug 25, 2023
|
I believe CI will pass after merging up from |
|
I took the liberty of merging up from main to fix the CI tests. I'll plan to merge this PR once they pass |
…ion into remove-lazy-static
|
Thanks @sarutak |
|
Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7408
Rationale for this change
As of Rust 1.70, we can use
OnceLockas a standard Rust library.So, this PR proposes to replace
lazy_staticwithOnceLockto reduce third-party dependency.Are these changes tested?
Done by existing tests.
Are there any user-facing changes?
No