Minor: Extract ExecutionPlanVisitor to its own module #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
approved these changes
Aug 9, 2023
alamb
changed the title
|
Thank you for the review @crepererum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1754
Rationale for this change
I am trying to improve the code structure of DataFusion -- I tried to remove this function and replace it with the TreeNode API but I was not successful. At least I can pull this code into its own module to make it easier to find
What changes are included in this PR?
Move ExecutionPlanVisitor and some related functions into their own
visitor.rsmoduleAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
No -- I left
pub useso no changes should be needed