-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Port remaining information_schema rust tests to sqllogictests #7050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I ported these tests to a new .slt file since one of the tests creates multiple catalogs it changes the results of some existing tests and causes a few errors in the I was not able to port two things because I wasn't able to figure out a valid SQL syntax to do so:
|
Thank you so much @palash25 -- 😍 In terms of setups that can not be achieved via SQL today, I recommend we follow the approach of some other similar tests and set them up programatically (move the setup rust code into sqllogictest): Does that make sense? |
thank you, i didn't know we could use rust code with logic tests, i will take a look at this tomorrow and try to finish it up |
Closes: apache#6301 Signed-off-by: Palash Nigam <npalash25@gmail.com>
18c46d0
to
552ec9e
Compare
@alamb its ready for review. I used rust code to set things up for two of the tests as you suggested:
I had to split the tests into separate .slt files because even though i was able to set things up correctly with setup.rs there was no way to cleanup things properly and that would mess with the output of some other test. Hope thats ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @palash25 -- thank you very much 🙏
I took the liberty of merging up from main and fixing the clippy error on this PR. Hopefully we can get it merged tomorrow. Thanks again @palash25 |
thanks for the clippy fixes, i didn't notice them. I just pushed a small commit removing unnecessary comments that were left out in the original commit. Looking forward to contributing more in the future, it was a really nice experience to contribute to this project. 😄 |
Thank you for saying so. We strive to make it pleasant and have people work well together as a community so it is nice to have that acknowledged |
Which issue does this PR close?
Closes: #6301
Rationale for this change
This ports the remaining information_schema tests to sqllogic tests
What changes are included in this PR?
The file containing rust tests for information schema has been completely deleted. And the 3 rust tests from that file have been ported to sql logic tests residing in a separate
.slt
fileAre these changes tested?
Yes i did run
cargo test
there were a few ignored tests but no failuresAre there any user-facing changes?
No