Test: Use unchecked group_value access in group hash #7010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
Contributor
Author
|
I will post some numbers when I have them |
This was referenced Jul 18, 2023
Contributor
Author
|
Here are my benchmark results: #6969 (comment) (TLDR they are mixed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6969
Inspired by the @yahoNanJing 's work in apache/arrow-rs#4524 (comment) I am seeing how much extra performance there is to be gained via inlining and unchecked access in group keys: apache/arrow-rs#4539
I think there is still substantial performance to be had by avoiding the row format entirely for single column groups, but I will explore that theory later