Remove RowAccumulators and datafusion-row #6968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
force-pushed
the
alamb/remove_row_accumulator
branch
from
50ea550 to
f871f56
Compare
alamb
changed the title
This was referenced Jul 14, 2023
alamb
force-pushed
the
alamb/remove_row_accumulator
branch
from
d3f441c to
22370ea
Compare
tustvold
approved these changes
Jul 19, 2023
Dandandan
approved these changes
Jul 19, 2023
|
FYI @yjshen and @yahoNanJing -- I plan to merge this in a few days unless I hear otherwise |
|
I'm free to remove this. However, I hope to implement multiple row format in arrow-row:
|
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6798
Part of #6889
Rationale for this change
The new grouping introduced in #6904 is faster than
RowAccumulatorsand thus we do not needRowAccumulatorcode anymoreThe
RowAccumulatorwere the last user of thedatafusion-rowcrate -- we now fully use the upstreamarrow_rowcrate https://docs.rs/arrow-row/43.0.0/arrow_row/index.htmlWhat changes are included in this PR?
RowAccumulatorsdatafusion-rowcrateAre these changes tested?
existing coverage
Are there any user-facing changes?
No