Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Move PartitionStream to physical_plan #6756

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 23, 2023

Which issue does this PR close?

Part of #1754

Rationale for this change

To split out physical_plan it can't depend on datasource (which is in the datafusion core crate now)

What changes are included in this PR?

Move PartitionStream to physical_plan

Are these changes tested?

N/A

Are there any user-facing changes?

In theory, yes, if anyone uses this API, which I think will not be many people as it is fairly new

@alamb alamb marked this pull request as ready for review June 23, 2023 19:02
@github-actions github-actions bot added the core Core DataFusion crate label Jun 23, 2023
@alamb alamb marked this pull request as draft June 23, 2023 19:02
@alamb alamb marked this pull request as ready for review June 23, 2023 19:04
@alamb alamb changed the title Move PartitionStream to physical_plan Minor: Move PartitionStream to physical_plan Jun 23, 2023
@alamb alamb added the api change Changes the API exposed to users of the crate label Jun 23, 2023
Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackwener jackwener merged commit 878fec1 into apache:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants