Add percentile_cont aggregation function #6718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor median to use the PercentileContAccumulator with percentile 0.5
github-actions
bot
added
core
Contributor
|
Hi @jonmmease, I'm curious why this was closed |
Contributor
Author
|
As I recall, I ran into some precision issue when I tried to re-implement |
Contributor
Thank you for clarifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6714
What changes are included in this PR?
Adds the Postgres
PERCENTILE_CONTaggregation function. Refactors the median aggregation to use the newPercentileContAccumulatorwith percentile 0.5.In order to match the precision of the existing median tests I needed to use BigDecimal values for the linear interpolation step.
Are these changes tested?
Yes, tests added to
datafusion/core/tests/sqllogictests/test_files/aggregate.slt.Are there any user-facing changes?
Yes, the
percentile_contaggregation function is now available in SQL