Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename integration tests to match crate they are defined in #6687

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 15, 2023

Which issue does this PR close?

N/A

Rationale for this change

While working on #6682 I noticed that the names of some or our integration tests are very confusing.
Specifically

cargo test --test

error: "--test" takes one argument.
Available tests:
    aggregate_fuzz
    config_from_env
    custom_sources
    dataframe
    dataframe_functions
    fifo
    integration-test               <-- these tests differ by 1 character! (this is in the sql crate)
    integration_test               <-- '_'  (this is in the optimizer crate)
    join_fuzz
    memory_limit
    merge_fuzz
    order_spill_fuzz
    parquet_exec
    path_partition
    provider_filter_pushdown
    repartition
    roundtrip_logical_plan
    roundtrip_physical_plan
    row
    serialize
    simplification
    sql_integration               <-- this is in the core crate, not the sql crate
    sqllogictests
    statistics
    tpcds_planning
    user_defined_aggregates
    user_defined_plan
    window_fuzz

What changes are included in this PR?

Rename the tests so:

Available tests:
    aggregate_fuzz
    config_from_env
    core_integration        <-- in the core crate
    custom_sources
    dataframe
    dataframe_functions
    fifo
    join_fuzz
    memory_limit
    merge_fuzz
    optimizer_integration        <-- in the optimizer crate
    order_spill_fuzz
    parquet_exec
    path_partition
    provider_filter_pushdown
    repartition
    roundtrip_logical_plan
    roundtrip_physical_plan
    row
    serialize
    simplification
    sql_integration        <-- in the sql crate
    sqllogictests
    statistics
    tpcds_planning
    user_defined_aggregates
    user_defined_plan
    window_fuzz

Are these changes tested?

CI runs these tests

Are there any user-facing changes?

no this is a developer experience only

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules sql SQL Planner labels Jun 15, 2023
@alamb alamb merged commit 3ce75b3 into apache:main Jun 16, 2023
@alamb alamb deleted the alamb/rename_integration_Test branch June 16, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate optimizer Optimizer rules sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants