Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: combine fuzz tests into a single binary to save builder space and build time #6684

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 15, 2023

Which issue does this PR close?

Part of #6676

Rationale for this change

This is the same pattern applied in #6682

Basically, each test binary has about 125MB of overhead (the size of the datafusion code that is linked in) . Thus I estimate this PR to save ~1GB of builder space (instead of 5 different binaries each about 125MB, there is a single binary that is 127MB)

What changes are included in this PR?

combine fuzz tests into a single binary to save builder space and build time

Are these changes tested?

Yes

Are there any user-facing changes?

no

@github-actions github-actions bot added the core Core DataFusion crate label Jun 15, 2023
@alamb alamb added the development-process Related to development process of DataFusion label Jun 15, 2023
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 0d82620 into apache:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants