refactor: unify replace count(*) analyzer by removing it in sql crate #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: CountWildcardRule ignore Expr::Alias
github-actions
bot
added
core
jackwener
commented
Jun 13, 2023
| @@ -881,7 +881,7 @@ fn select_aggregate_with_having_referencing_column_not_in_select() { | |||
| assert_eq!( | |||
| "Plan(\"HAVING clause references non-aggregate values: \ | |||
| Expression person.first_name could not be resolved from available columns: \ | |||
| COUNT(UInt8(1))\")", | |||
| COUNT(*)\")", | |||
There was a problem hiding this comment.
sql-crate don't replace count(*).
we use rule to replace unified count(*).
alamb
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
It makes a lot of sense to me to use a rewrite that is in the optimizer (so it happens as part of any plan, not just SQL plans). Thanks @jackwener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?