fix: port unstable subquery to sqllogicaltest #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
jackwener
changed the title
alamb
approved these changes
Jun 13, 2023
| --------------AggregateExec: mode=Partial, gby=[t2_id@0 as t2_id], aggr=[SUM(t2.t2_int)] | ||
| ----------------MemoryExec: partitions=4, partition_sizes=[1, 0, 0, 0] | ||
|
|
||
| query II |
There was a problem hiding this comment.
I think you have to put rowsort on this line to make sure the order is consistent given the query doesn't ensure it:
Suggested change
| query II | |
| query II rowsort |
Thanks @jackwener
[Diff] (-expected|+actual)
+ 22 1
33 NULL
11 3
- 22 1
44 3
at tests/sqllogictests/test_files/subquery.slt:137
There was a problem hiding this comment.
Yes, I have just added. Thanks for reminder
There was a problem hiding this comment.
Yes, I think the unstable is due to result without sorting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
#6457 add some unstable test.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?