refactor: unify generic expr rewrite functions into the datafusion_expr::expr_rewriter
#6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpr::expr_rewriter`
github-actions
bot
added
core
alamb
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Thank you @r4ntix -- this looks like a nice improvement to me. I marked it as an API change too as I think some of the functions used are marked pub so downstream code will have to update their use statements if they use these functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6643
Rationale for this change
See #6643
What changes are included in this PR?
move
unalias,rewrite_preserving_namerewrite functions into thedatafusion_expr::expr_rewritermod.Are these changes tested?
Are there any user-facing changes?