Return correct scalar types for date_trunc #6638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Jun 11, 2023
| @@ -329,7 +329,7 @@ pub fn date_trunc(args: &[ColumnarValue]) -> Result<ColumnarValue> { | |||
| } | |||
| _ => { | |||
| return Err(DataFusionError::Execution( | |||
| "array of `date_trunc` must be non-null scalar Utf8".to_string(), | |||
There was a problem hiding this comment.
This error message also doesn't read correctly.
alamb
approved these changes
Jun 12, 2023
jackwener
approved these changes
Jun 12, 2023
|
Follow on discussion in #6653 |
|
Thanks. @alamb @jackwener |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
This is inspired when I review #6632 and read the date_trunc implementation. Based on its signature, date_trunc always returns nanosecond timestamp, but for scalar case, it actually returns second/millisecond/microsecond scalar values. This patch fixes the mismatched scalar types.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?