fix: analyze/optimize plan in CREATE TABLE AS SELECT
#6610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
|
If plan didn't be analyzed, it will fail to execute in let schema = Arc::new(input.schema().as_ref().into());
let physical = DataFrame::new(self.state(), input);
let batches: Vec<_> = physical.collect_partitioned().await?;
let table = Arc::new(MemTable::try_new(schema, batches)?); |
jackwener
changed the title
CREATE TABLE AS SELECTCREATE TABLE AS SELECT
alamb
approved these changes
Jun 9, 2023
| @@ -495,6 +495,7 @@ impl SessionContext { | |||
| } | |||
|
|
|||
| let input = Arc::try_unwrap(input).unwrap_or_else(|e| e.as_ref().clone()); | |||
| let input = self.state().optimize(&input)?; | |||
There was a problem hiding this comment.
That is important 👍
I wonder if there is any test we can add to cover this case and prevent a regression?
There was a problem hiding this comment.
I have tried to add test to cover this case, but failed.
Because when I try to add test explain to show plan tree, but if sql is explain, df don't execute these code.
So I don't know how to cover it.
|
Thanks @jackwener |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
related #5821.
we need analyze plan to make plan valid.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?