Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid panic in list_files_for_scan #6605

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

Folyd
Copy link
Contributor

@Folyd Folyd commented Jun 9, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

A surprise panic would raise in list_files_for_scan if the table_paths is empty, I think this can be avoided.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Jun 9, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @Folyd

@alamb alamb merged commit 1a1efcf into apache:main Jun 9, 2023
@Folyd Folyd deleted the fix-panic branch June 9, 2023 12:29
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants