Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datafusion-cli tests to the CI Job #6600

Merged
merged 5 commits into from
Jun 11, 2023
Merged

Add datafusion-cli tests to the CI Job #6600

merged 5 commits into from
Jun 11, 2023

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Jun 8, 2023

Which issue does this PR close?

Closes #6577

Rationale for this change

See #6577

What changes are included in this PR?

Add cargo test, cargo doc of datafusion-cli to the CI Job

Are these changes tested?

Yes

Are there any user-facing changes?

None

@r4ntix r4ntix marked this pull request as draft June 8, 2023 12:03
@r4ntix r4ntix marked this pull request as ready for review June 11, 2023 13:57
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice -- thank you @r4ntix 🏅

run: |
cargo test --doc --features avro,json
cd datafusion-cli
cargo test --doc --all-features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit a2d3c3c into apache:main Jun 11, 2023
@r4ntix r4ntix deleted the issue-6577 branch June 12, 2023 06:15
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Jun 12, 2023
* Add datafusion-cli tests to the CI Job

* Fix clippy error of datafusion-cli

* update tests of datafusion-cli

* fix tests error of datafusion-cli

* Splits out "cargo test datafusion-cli (amd64)" into separate CI job, fix "no space left on device" error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why exclude datafusion-cli from workspace?
2 participants