Revert "feat: Implement the bitwise_not in NotExpr (#5902)" #6599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 87e5adc
github-actions
bot
added
core
jackwener
commented
Jun 8, 2023
| @@ -911,17 +911,15 @@ SELECT not(true), not(false) | |||
| ---- | |||
| false true | |||
|
|
|||
| query BB | |||
| query error DataFusion error: Optimizer rule 'simplify_expressions' failed\ncaused by\nInternal error: NOT 'Literal \{ value: Int64\(1\) \}' can't be evaluated because the expression's type is Int64, not boolean or NULL\. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker | |||
There was a problem hiding this comment.
It should fail in type coercion, it's a future ticket.
We should try to cast param. (if fail cast then throw a error)
|
wait for opinion of @liukun4515 in #6589 |
|
cc @RTEnzyme who originally contributed this code. |
comphead
approved these changes
Jun 8, 2023
alamb
approved these changes
Jun 8, 2023
|
I agree that |
jayzhan211
pushed a commit
to jayzhan211/datafusion
that referenced
this pull request
Jun 12, 2023
…ache#6599) This reverts commit 87e5adc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 87e5adc
Which issue does this PR close?
Closes #6589
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?