Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix for the Debug of FileScanConfig #6454

Merged
merged 1 commit into from
May 26, 2023
Merged

Minor fix for the Debug of FileScanConfig #6454

merged 1 commit into from
May 26, 2023

Conversation

yahoNanJing
Copy link
Contributor

Which issue does this PR close?

Closes #6453.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label May 26, 2023
@yahoNanJing
Copy link
Contributor Author

yahoNanJing commented May 26, 2023 •
edited
Loading

Hi @alamb, for #6359, I made a mistake of forgetting to add ", " for the fields of object_store_url and statistics. Could you help have a check?

alamb
alamb approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @yahoNanJing

@alamb alamb merged commit 9e8e096 into apache:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor fix for the Debug info of FileScanConfig
3 participants
@yahoNanJing @alamb @kyotoYaho