Skip to content

Port tests in explain.rs to sqllogictests #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

Port tests in explain.rs to sqllogictests #6343

merged 1 commit into from
May 12, 2023

Conversation

my-vegetable-has-exploded
Copy link
Contributor

Which issue does this PR close?

Closes #6297.

Rationale for this change

#6195.

What changes are included in this PR?

remove explain.rs and tests EXPLAIN VERBOSE in sqllogictests.

Are these changes tested?

yes.

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels May 12, 2023
r4ntix
r4ntix approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @my-vegetable-has-exploded

@alamb
Copy link
Contributor

alamb commented May 12, 2023

Thanks @my-vegetable-has-exploded and @r4ntix ❤️

@alamb alamb merged commit 9ae370c into apache:main May 12, 2023
@my-vegetable-has-exploded my-vegetable-has-exploded deleted the port-explain-test branch December 6, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4ntix r4ntix r4ntix approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port tests in explain.rs to sqllogictests
3 participants
@my-vegetable-has-exploded @alamb @r4ntix