Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Expr::Exists to use a struct. #6292

Merged
merged 1 commit into from
May 9, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented May 9, 2023

Which issue does this PR close?

Related to #2175 and #3807.

Rationale for this change

What changes are included in this PR?

Refactor Expr::Exists to a struct.

Are these changes tested?

Yes.

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner labels May 9, 2023
@QuenKar
Copy link
Contributor Author

QuenKar commented May 9, 2023

When I run cargo test, I met a question.

thread 'tpcds_logical_q64' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`

I found that this test used a lot of tables, and it says that stack overflow. How can I pass this test?

@jackwener
Copy link
Member

When I run cargo test, I met a question.

thread 'tpcds_logical_q64' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`

I found that this test used a lot of tables, and it says that stack overflow. How can I pass this test?

You can ignore it, it's a known issue #6277

@QuenKar QuenKar changed the title Refactor Expr::Exists to a struct. refactor: Expr::Exists to use a struct. May 9, 2023
@jackwener
Copy link
Member

Nice job, Thank you @QuenKar

jackwener
jackwener previously approved these changes May 9, 2023
@jackwener jackwener dismissed their stale review May 9, 2023 07:16

find some problem

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved conflicts.
Thanks @QuenKar 's contribution.
LGTM

@QuenKar
Copy link
Contributor Author

QuenKar commented May 9, 2023

I have resolved conflicts. Thanks @QuenKar 's contribution. LGTM

Thank you!

@jackwener jackwener merged commit 4ff1d94 into apache:main May 9, 2023
@QuenKar QuenKar deleted the quenkar-dev-exists branch May 11, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants