-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Expr::Exists to use a struct. #6292
Conversation
When I run
I found that this test used a lot of tables, and it says that stack overflow. How can I pass this test? |
You can ignore it, it's a known issue #6277 |
Nice job, Thank you @QuenKar |
0ce227d
to
ac53da3
Compare
ac53da3
to
d863004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have resolved conflicts.
Thanks @QuenKar 's contribution.
LGTM
Thank you! |
Which issue does this PR close?
Related to #2175 and #3807.
Rationale for this change
What changes are included in this PR?
Refactor Expr::Exists to a struct.
Are these changes tested?
Yes.
Are there any user-facing changes?