Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests in functions.rs to sqllogictest #6256

Merged
merged 1 commit into from
May 8, 2023

Conversation

parkma99
Copy link
Contributor

@parkma99 parkma99 commented May 6, 2023

Which issue does this PR close?

Closes #6211

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels May 6, 2023
Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @parkma99

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @parkma99

@jackwener jackwener merged commit dcc5feb into apache:main May 8, 2023
@alamb
Copy link
Contributor

alamb commented May 8, 2023

AMazing -- thank you so much @parkma99

@parkma99 parkma99 deleted the functions branch May 9, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port tests in functions.rs to sqllogictest
4 participants