Skip to content

Port tests in identifiers.rs to sqllogictest #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2023
Merged

Port tests in identifiers.rs to sqllogictest #6245

merged 3 commits into from
May 5, 2023

Conversation

parkma99
Copy link
Contributor

@parkma99 parkma99 commented May 5, 2023

Which issue does this PR close?

Closes #6212

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels May 5, 2023
@jackwener
Copy link
Member

Please rebase latest code to avoid error

@parkma99
Copy link
Contributor Author

parkma99 commented May 5, 2023

Please rebase latest code to avoid error

OK,Thanks

alamb
alamb approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parkma99 -- I took the liberty of merging up from main and removing identifier.rs from this PR.

It is quite a nice set of PRs you have made. Really nice and very much appreciated 🙏

@alamb alamb merged commit 885bdc1 into apache:main May 5, 2023
@parkma99 parkma99 deleted the identifiers branch May 5, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port tests in identifiers.rs to sqllogictest
3 participants
@parkma99 @jackwener @alamb